search

libts / tslib

Touchscreen access library
GNU Lesser General Public License v2.1
625 stars 292 forks source link

tweak punctuation, wording, etc. #183

Closed RichMorin closed 4 years ago

RichMorin commented 4 years ago

The change includes numerous small tweaks to punctuation, wording, etc. I didn't try to change "...and include directories generated build files." because I can't figure out what it's supposed to mean. Help?

merge commented 4 years ago

The change includes numerous small tweaks to punctuation, wording, etc. I didn't try to change "...and include directories generated build files." because I can't figure out what it's supposed to mean. Help?

@skirk you added this sentense during https://github.com/libts/tslib/pull/137/files what did you mean?

merge commented 4 years ago

thanks a lot for looking over it! I'm not convined about all the oxford commas, but I'm leaning towards merging...

skirk commented 4 years ago

The change includes numerous small tweaks to punctuation, wording, etc. I didn't try to change "...and include directories generated build files." because I can't figure out what it's supposed to mean. Help?

@skirk you added this sentense during https://github.com/libts/tslib/pull/137/files what did you mean?

I suppose it should read ".. to the generated build files". To be fair, I think the whole sentence can be omitted or replaced with something like: The library adds tslib::tslib target and all the client needs to do is to link against it.

RichMorin commented 4 years ago

On Sep 15, 2020, at 05:47, Martin Kepplinger notifications@github.com wrote:

thanks a lot for looking over it! I'm not convined about all the oxford commas, but I'm leaning towards merging...

"I'd like to thank my parents, God and Mother Teresa."

-r