Add a bunch of sanity checks

libusb / hidapi

A Simple cross-platform library for communicating with HID devices

https://libusb.info/hidapi/

Other

1.68k stars 398 forks source link

Add a bunch of sanity checks #696

Open Megamouse opened 1 month ago

Megamouse commented 1 month ago

Some of these changes are meant to fix a couple of warnings while reading the code. I also noticed that there were almost no sanity checks in the code, which may lead to lots of segfaults in user code.

Win: Do not call CloseHandle in hid_open_path if device_handle is null
Win: return errors if malloc calls fail
Add missing NULL checks to many parameters

Megamouse commented 1 month ago

I think I made all the necessary changes.

Youw commented 1 month ago

NOTE: in #698 I've added some of those

Megamouse commented 1 month ago

If you tell me what to keep and what to remove I can adjust this soon