Add CI for all platforms

libusb / libusb-cmake

CMake build system for libusb

https://github.com/libusb/libusb

GNU Lesser General Public License v2.1

26 stars 12 forks source link

Add CI for all platforms #7

Open Youw opened 1 year ago

Youw commented 1 year ago

[x] Linux (Ubuntu?) #6
[x] macOS #11
[x] Windows MSVC/VisualStudio #12
[x] Windows MSVC/Ninja/nmake #12
[ ] Windows Cygwin/MinGW
[ ] (Fedora?) Cross-compile MinGW
[ ] OpenBSD
[ ] NetBSD
[x] Android NDK

Any other platforms?

mcuee commented 1 year ago

I changed FreeBSD to NetBSD as FreeBSD has their own version of libusb under BSD licenses and it is part of the FreeBSD system (not an add-on).

mcuee commented 1 year ago

There are other platforms like Solaris and Haiku but I guess we may not want to deal with them.

Reference:

https://github.com/libusb/libusb/issues/1099

mcuee commented 1 year ago

@Youw

I have no ideas about WebAssembly + WebUSB support. https://github.com/libusb/libusb/wiki#supported-environments

mcuee commented 1 year ago

@Youw

For the CI action, it will be good to keep the binaries as well, at least for Windows (MSVC x86/x64/ARM/ARM64 and MinGW x86/x64).

Youw commented 1 year ago

There are other platforms like Solaris and Haiku but I guess we may not want to deal with them.

My thoughs: right now it is not a part of CMake implementation. As soon as someone needs those (and adds its support to CMakeLists.txt) - we will think about a CI for it too.

Youw commented 1 year ago

good to keep the binaries as well

I'm not so sure about that. Not any time soon. Firstly - because CMake is not an official build system for libusb. Secondly - the main purpose of this repo is to be able to build libusb with CMake.

If someone needs a prebuilt binaries - that better be provided by a mainline libusb repo/be a part of its release process/etc.

Sure, it will be useful for some, e.g. temporary binaries saved as part of a PR (e.g. to verify a bugfix for someone or so). But I don't want people to expect to find prebuilt binaries here. And even the bugfix verification - that's more about PRs to libusb itself, not to libusb-cmake.

mcuee commented 1 year ago

@Youw

I agree with you now, not to keep the binary as this is not official libusb. Rather we should improve libusb github action to keep Windows binaries, not in libusb-cmake.