search

libvarun / forge-extensions

Autodesk Forge Viewer Extensions with loose coupling, so that it's easy to plug and play in other projects.
https://forge-extensions.autodesk.io/
4 stars 4 forks source link

document.ready? #10

Closed augustogoncalves closed 4 years ago

augustogoncalves commented 4 years ago

shouldn't this be inside the document ready event? may fail on slow connection...

https://github.com/libvarun/StandardExtensions/blob/master/public/StandardExtensions/extensionloader.js#L3

libvarun commented 4 years ago

list is created after model is loaded in the viewer, so it won't be a problem. https://github.com/libvarun/StandardExtensions/blob/master/public/StandardExtensions/extensionloader.js#L20

augustogoncalves commented 4 years ago

right, but in this case the loadJSON is called on the beginning, while the method is only defined in the end. in case of a very slow connection, you may get a "method undefined" error.

libvarun commented 4 years ago

done.