search

libvarun / forge-extensions

Autodesk Forge Viewer Extensions with loose coupling, so that it's easy to plug and play in other projects.
https://forge-extensions.autodesk.io/
4 stars 4 forks source link

suggestions for NestedViewerExtension #14

Closed augustogoncalves closed 4 years ago

augustogoncalves commented 4 years ago

nice work @petrbroz !

can we add:

  1. readme on the extension folder (general how the code works, limitations, author, etc.)
  2. link to it from the app (see #2 @libvarun )

and maybe add (not major)

  1. resizable?
  2. toolbar button with push style (on/off)

some expected behavior (from other samples):

  1. click on the nested, highlight/select on the main? (and vice-versa)
  2. option on the config.json to show only 2D (or only 3D)?
petrbroz commented 4 years ago

Sounds good. Let me look into that.

petrbroz commented 4 years ago

All of the suggestions above are addressed in https://github.com/libvarun/forge-extensions/pull/15.

augustogoncalves commented 4 years ago

it seems the select is inheriting the text color from bootstrap, therefore white over white

image

petrbroz commented 4 years ago

Thanks, I'll fix that.

petrbroz commented 4 years ago

https://github.com/libvarun/forge-extensions/pull/17