search

libvibrant / vibrantDeck

Plugin for the Steam Deck, to adjust color settings, like saturation or gamma
GNU Lesser General Public License v3.0
137 stars 7 forks source link

More color correction options #1

Open outerwinnie opened 2 years ago

outerwinnie commented 2 years ago

Hi! I was wondering is it would be possible to add color correction settings to the plugin, with the objetive of manage something like this but system wide:

https://www.reddit.com/r/SteamDeck/comments/wd2fa7/get_a_more_color_accurate_steam_deck_files/ https://www.reddit.com/r/SteamDeck/comments/v80w7u/steam_deck_display_calibration_v2/

Thanks for your work! Amazing plugin!

Scrumplex commented 2 years ago

I don't think you can set LUTs directly, as they are used in those posts. But color correction is definitely possible.

For future reference, these are all color values, that can be altered in Gamescope: https://github.com/Plagman/gamescope/blob/3122d1aabec4d8f7df79edb1b76e136c0dd5ffbf/src/steamcompmgr.cpp#L4937-L4942

outerwinnie commented 2 years ago

Well, it would be amazing if you add those options at some point! Thanks again!

aizakow commented 2 years ago

I second this! Some way to match the calibration of those reshade configs would be amazing

crystalclear23 commented 2 years ago

I third this.

rc2189 commented 2 years ago

It seems like changing the gamma would be the next best addition:

GAMESCOPE_COLOR_GAMMA_EXPONENT

I tinkered around with it for a little while but never got it fully working

rc2189 commented 2 years ago

@Scrumplex any chance you can add settings to change the gamma? In my opinion the deck could really benefit from those changes! I can collaborate if needed

Scrumplex commented 2 years ago

I have looked at the relevant code inside gamescope. That variables takes six float values. The first three are the exponents for degamma (I assume R, G and B) and the latter three are for gamma (also R, G and B). Does anyone know what degamma is? :D

rc2189 commented 2 years ago

I have looked at the relevant code inside gamescope. That variables takes six float values. The first three are the exponents for degamma (I assume R, G and B) and the latter three are for gamma (also R, G and B). Does anyone know what degamma is? :D

I only dug through a bit, but that would make sense RGB then Gamma. Hopefully this is something that can be accomplished!

rc2189 commented 2 years ago

I see a commit for this, huge thank you for considering adding the gamma! Hugely appreciated!

crystalclear23 commented 2 years ago

How do you install the new version or do I just wait for it on decky?

Scrumplex commented 2 years ago

Gamma support is basically ready with PR #8.

I asked in Decky Discord for people to test it. If no issues surface, I will release a new version with gamma setting soon

rc2189 commented 2 years ago

Fantastic, thank you!

crystalclear23 commented 2 years ago

Is there a way to edit the index.js so that the increments are like 5 instead of 50

aizakow commented 2 years ago

The latest version appears to disable night mode whenever I launch a game, permanently until I go into system settings and turn it back on. Is this intended behavior? I sort of see the reasoning, but a toggle might be nice

Scrumplex commented 2 years ago

Is there a way to edit the index.js so that the increments are like 5 instead of 50

I can't influence that sadly. If you use the touchscreen, you can set finer values

Scrumplex commented 2 years ago

The latest version appears to disable night mode whenever I launch a game, permanently until I go into system settings and turn it back on. Is this intended behavior? I sort of see the reasoning, but a toggle might be nice

Steam also uses some way of editing gamma values. I am still not sure how they do it, but you (currently) can't have both