search

libvips / build-win64

build libvips for 64-bit windows
28 stars 14 forks source link

Ensure gdk-pixbuf can find libjpeg-turbo when cross-compiling #28

Closed lovell closed 5 years ago

lovell commented 5 years ago

One of the sharp unit tests was failing to render an embedded JPEG within an SVG on Windows with the latest 8.8.0 release. This was due to gdk-pixbuf being unable to find libjpeg-turbo at compile time.

With the change in this PR, to use the libjpeg 8 ABI and search for it via pkg-config, the binaries it provides now allows all the sharp tests to pass.

(I guess we could also submit a variant of this patch upstream to the gdk-pixbuf project to use meson's dependency as a fallback for find_library.)

This PR also bumps vips from a release candidate to the supported v8.8.0.

jcupitt commented 5 years ago

This is a good find @lovell, I'd never noticed the failure before. Nice!