search

libvips / nip2

A spreadsheet-like GUI for libvips.
https://libvips.github.io/libvips/
GNU General Public License v2.0
360 stars 13 forks source link

bootstrap fails on Fedora 18 #35

Closed bgilbert closed 11 years ago

bgilbert commented 11 years ago

Since af001726, bootstrap.sh says:

configure.ac:237: error: possibly undefined macro: AC_FUNC_MKDIR
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

This leads to a configure warning:

checking for alloca... yes
checking for working POSIX fnmatch... yes
./configure: line 16122: AC_FUNC_MKDIR: command not found
checking for vprintf... yes
checking for _doprnt... no

and ultimately a build failure:

gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/include/graphviz   -pthread -I/usr/include/libgoffice-0.8 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libgsf-1 -I/usr/include/libxml2 -I/usr/include/gtk-2.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gconf/2 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm -I/usr/include/harfbuzz -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include      -pthread -fopenmp -D_REENTRANT -I/home/bgilbert/include/openslide -I/home/bgilbert/include -I/home/bgilbert/vips/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/libdrm -I/usr/include/harfbuzz -I/usr/include/libxml2 -I/usr/include/ImageMagick -I/usr/include/orc-0.4 -I/usr/include/OpenEXR -I/usr/include/cfitsio    -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS     -g -O2 -MT nip2-vipsobject.o -MD -MP -MF .deps/nip2-vipsobject.Tpo -c -o nip2-vipsobject.o `test -f 'vipsobject.c' || echo './'`vipsobject.c
In file included from vipsobject.c:30:0:
ip.h:245:4: error: #error "Don't know how to create a directory on this system."
make[3]: *** [nip2-vipsobject.o] Error 1
jcupitt commented 11 years ago

I thought this was an OS change. I installed autoconf-archive, the package on Debian with the AC_FUNC_MKDIR macro definition, and the problem went away.

jcupitt commented 11 years ago

I suppose a better fix would be to use the glib mkdir wrapper rather than our own. libvips seems to use mkdir as well, I forget why. I'll make a patch.

bgilbert commented 11 years ago

Ah! Fedora also has autoconf-archive, and that does fix it. Perhaps it's worth mentioning in the README, if you don't end up switching to g_mkdir().

Thanks.

jcupitt commented 11 years ago

Fixed with this: https://github.com/jcupitt/nip2/commit/fe9f43b0e25fe56dea8e2eda844c1a5a61603b39

There's a similar patch for libvips. Thanks Benjamin.

jcupitt commented 11 years ago

I should have said, the patches switch nip2/libvips to using g_mkdir().