libvips / nip2

A spreadsheet-like GUI for libvips.
https://libvips.github.io/libvips/
GNU General Public License v2.0
360 stars 13 forks source link

Simplify nip2-icon.o build #59

Closed bgilbert closed 8 years ago

bgilbert commented 8 years ago

Don't generate nip2-icon.rc at build time, and only build nip2-icon.o on Windows. Fixes warning when building on MacPorts:

dummy.c:1:14: warning: control reaches end of non-void function [-Wreturn-type]

Fixes make dist failure if run before make:

make[2]: *** No rule to make target '../src/dummy.c', needed by 'nip2.pot'.  Stop.

Tested on a Linux build, but not on a Windows build.

jcupitt commented 8 years ago

Looks very reasonable, thank you Benjamin.

I've no idea why it was set up like that before :( I suppose it seemed necessary at the time.