Fix compilation with ICU 68

libvips / nip2

A spreadsheet-like GUI for libvips.

https://libvips.github.io/libvips/

GNU General Public License v2.0

360 stars 13 forks source link

Fix compilation with ICU 68 #96

Closed afontenot closed 2 years ago

afontenot commented 3 years ago

Pretty simple, I tried to compile this on Arch Linux and couldn't because of recent changes to ICU. I fixed the issue:

nip2 depends on the ICU library via libxml2. ICU released version 68 on 2020-10-28, and switched to using the C99 bool type in its public headers. nip2 was using bool as the name for a gboolean in the ParseConst struct. This commit renames this to boolean.

agoode commented 2 years ago

This seems to be needed to fix https://bugzilla.redhat.com/show_bug.cgi?id=2046769

jcupitt commented 2 years ago

Sorry @afontenot, your very useful PR fell off my radar :(

Thank you for doing this work!