Open jcupitt opened 7 years ago
More abstract points:
libvips has several ways to make images: new_from_file
, new_from_buffer
etc. At the moment these are extra helper functions hanging off the main Image
constructor, but there's probably a better way.
It's very fragile: new Image(12);
, for example, will segv immediately. Perhaps there should be some argument checking.
It ended up mostly being copy-pasted from pyvips, since that was the one I'd done most recently and probably has the best internal structure. That would be a good place to copy-paste docs from, eg.:
https://github.com/jcupitt/pyvips/blob/master/pyvips/vimage.py#L196
Any chance v1 will come out soon? Would you say this is production worthy atm?
Thanks @asilvas. I only ask because there's little documentation and
It's very fragile: new Image(12);, for example, will segv immediately. Perhaps there should be some argument checking.
From the above comment.
Actually I responded thinking it was vips, sorry. I do not have any experience with this package.
I thought you might've :) I checked out your package image-steam
a few days ago and it's pretty cool! I'm trying to build something similar. And I'm checking out node-vips for this because sharp doesn't expose all the functionality that vips offers.
I'm reluctant to declare 1.0 because I'm really not a node programmer -- I'm sure I've done all sorts of horrible things :(
This package needs someone experienced to look it over and fix it up, or we'll get users who will have to live with ugly stupid stuff that we'll then have to support. Plus the remaining items in this TODO, of course.
I totally understand, thank you for the input and the awesome lib! :)
Things that need doing before we could declare 1.0, in no order:
newFromFile()
, for example.bandsplit()
and.bandjoin()
? Should they be.bandSplit()
and.bandJoin()
?Image
, eg.Image.black
should be generated automatically.Image.prototype.bandsplit
Image.prototype.sin
Image.prototype.add
VipsInterpolate
example/thumb.js
in memory mode, investigatevips.call.async
Please add more!