search

libvips / php-vips

php binding for libvips
MIT License
615 stars 25 forks source link

Allowed for psr/log 2.0 and 3.0 to be installed as well #129

Closed boris-glumpler closed 2 years ago

boris-glumpler commented 2 years ago

This PR allows for any current psr/log version to be installed. I did have to bump the PHP version to 7.2 because of partial contravariance. Tests are passing, but there might be an issue with phpdocumentor/phpdocumentor as it still requires psr/log v1. Wasn't sure how to handle that.

fixes #128

jcupitt commented 2 years ago

Hi @boris-glumpler, thank you for doing this work.

I'm just finishing up php-vips 2.0 (it gets rid of the annoying binary extension and uses php 7.4's FFI to call into libvips instead). Could we merge this PR as part of that?

It should be finished in a few days (I hope). The branch is here, if you're curious:

https://github.com/libvips/php-vips/tree/switch-to-php-ffi

It runs most examples correctly, but a few tests still need fixing and it needs a bit of polish.

jcupitt commented 2 years ago

Sorry, I hadn't actually read your PR. It's very simple, so I've just merged.

I've merged it to the ffi branch as well, so it should be in 2.0.

boris-glumpler commented 2 years ago

Yup, it's not exactly complicated ;) Cheers! Looking forward to v2.0!