search

libvips / php-vips

php binding for libvips
MIT License
618 stars 25 forks source link

Avoid “Deprecate dynamic properties” warning in PHP 8.2 for the 1.x branch #174

Closed chregu closed 2 years ago

chregu commented 2 years ago

The same as https://github.com/libvips/php-vips/pull/159, just for the 1.x branch, since that still fails (obviously forgot about that) -> https://github.com/rokka-io/imagine-vips/actions/runs/3457135210/jobs/5770366829

Not sure you still wanna support that, but since it's an easy fix, why not ;)

jcupitt commented 2 years ago

Well remembered!

There's a new php-vips 2.x, did you see? It fixes a couple of small memory leaks.

chregu commented 2 years ago

Great, thanks. And saw the new release, that's why I realised with the tests in imageine-vips that we forgot this in the 1.x branch.