Allow `psr/log` v2 and v3 in v1.x branch

libvips / php-vips

php binding for libvips

MIT License

618 stars 25 forks source link

Allow `psr/log` v2 and v3 in v1.x branch #176

Closed PabloKowalczyk closed 1 year ago

PabloKowalczyk commented 1 year ago

Hello, is it possible to allow newer psr/log in 1.x branch? I know that php-vips-ext is deprecated, but using global FFI version without preload have performance and security impact, allowing newer psr/log on 1.x branch will allow projects to still use PECL version while waiting for preloaded v2. I could provide a PR.

jcupitt commented 1 year ago

Hi @PabloKowalczyk,

Sure, a PR would be great, thanks!

PabloKowalczyk commented 1 year ago

Turns out that the work was done before https://github.com/libvips/php-vips/commit/9080e310919285e4509d0564954c8c7468f84f06 and only missing piece is new release of v1, is it possible?

jcupitt commented 1 year ago

Ah I'd forgotten, sorry. I'll try to make 1.0.10.

jcupitt commented 1 year ago

I had a go. Would you mind testing?

PabloKowalczyk commented 1 year ago

Works, thank you.