search

libvips / php-vips

php binding for libvips
MIT License
615 stars 25 forks source link

[Feature Request] Renaming Second Parameter from width to length in thumbnail operations #212

Open AmitSonkhiya opened 1 year ago

AmitSonkhiya commented 1 year ago

Hi,

Do you think if it would be better to rename the second parameter width to length in *thumbnail related methods? For me, at the first glance, the name width in documents/code appears like the standard length in x axis strictly. And it misleads when the methods take higher side in consideration and create a 100x200px thumbnail for 400x800px vertical image when width = 200 is specified (with width = 200, it seems as a thumbnail with 200px length in x axis).

Thank you

jcupitt commented 1 year ago

We can't rename parameters in libvips without breaking API, so we can't make this change. The docs explain what the param means.