search

libvips / php-vips

php binding for libvips
MIT License
615 stars 25 forks source link

Fix broken assertion; minor other fixes #233

Closed uuf6429 closed 9 months ago

uuf6429 commented 9 months ago

Oops, I just realised this change is basically the same as #207.

This could be merged sooner if the other PR needs more time to be finished (otherwise you can also close this PR, as you wish).

jcupitt commented 9 months ago

Oops, I just realised this change is basically the same as https://github.com/libvips/php-vips/pull/207.

Do you mean #231? I'm getting a bit lost here :(

uuf6429 commented 9 months ago

Oops, I just realised this change is basically the same as https://github.com/libvips/php-vips/pull/207.

Do you mean #231? I'm getting a bit lost here :(

No no, you fixed the assertions in #207.

https://github.com/libvips/php-vips/pull/207/files#diff-7ba1b99b7a6b12a224cb86e5060a4b34530ad9a2c9fd224faa01845c97fddb34L226

I found that out after I had created the PR.