libvmi: Change to `vmi_get_max_physical_address`

libvmi / python

LibVMI Python bindings

http://libvmi.com/

GNU Lesser General Public License v3.0

30 stars 22 forks source link

libvmi: Change to `vmi_get_max_physical_address` #91

Closed netanelc305 closed 3 months ago

Wenzel commented 3 months ago

Thanks for this PR ! Although i don't understand why the CI passes, since i'm pinning a specific commit for libvmi ?

When did the API name changed ?

check the github actions libvmi setup: "e7074407fc3b98db1aa73f918b3720bd4438734b"

netanelc305 commented 3 months ago

Not sure when. I just tried to use the previous function and there way a mismatch and got this error AttributeError: cffi library '_libvmi' has no function, constant or global variable named 'vmi_get_max_physical_memory_address'. Did you mean: 'vmi_get_max_physical_address'? .

so i checked the name and saw it is diffent, after changing everything works fine :)

tklengyel commented 3 months ago

LGTM