search

libwww-perl / HTML-Parser

The HTML-Parser distribution is is a collection of modules that parse and extract information from HTML documents.
Other
6 stars 13 forks source link

Modernise XS #32

Closed JRaspass closed 2 years ago

JRaspass commented 2 years ago

Marking this draft for now as I'd like to have a discussion. This PR should probably be multiple PRs ranging from the uncontroversial (Adding 5.8 to GitHub CI so we actually test our min) to the slightly more controversial (the rest :-P).

Read the commit for details but I'm trying to modernise the XS by removing old compat code and switching to Devel::PPPort. Thoughts? Things like UNICODE_HTML_PARSER become a no-op hardcoded to true since we only support 5.8+ these days?

JRaspass commented 2 years ago

I wasn't sure about the dropping of

#ifdef __cplusplus
extern "C" {
#endif

I presume it's something to do with building with a C++ compiler? But I couldn't find any other modern XS dists using it, for example List::Util or JSON::XS. So I figured if it was okay for them then it should be fine for us.

oalders commented 2 years ago

@haarg did you still want to look at this or is it ok to merge?