libwww-perl / HTTP-Cookies

Objects that represent a "cookie jar"
https://metacpan.org/pod/HTTP::Cookies
Other
4 stars 17 forks source link

- Added warnings pragma as recommended by CPANTS. #40

Closed manwar closed 2 years ago

manwar commented 7 years ago

Hi,

Please review the PR.

Many Thanks. Best Regards, Mohammad S Anwar

oalders commented 7 years ago

Hi @manwar. Thanks for this!

Should we add Test::FailWarnings to the test suite to ensure that we're not introducing any new warnings?

manwar commented 7 years ago

Hi @oalders

That's brilliant idea and good catch.

Best Regards, Mohammad S Anwar

oalders commented 5 years ago

@manwar I apologize for losing track of this PR. Would you be able to resolve the conflicts and force-push your commits again?

manwar commented 5 years ago

Sure in a moment

oalders commented 2 years ago

@manwar is the feedback something you'd like to address? I promise to keep track of the PR this time. 😢

manwar commented 2 years ago

@manwar is the feedback something you'd like to address? I promise to keep track of the PR this time. 😢

Sure, I will look into this weekend, promise.

manwar commented 2 years ago

This is all messed up. I would rather create fresh pull request. Please ignore this pull request.