Closed manwar closed 2 years ago
Hi @manwar. Thanks for this!
Should we add Test::FailWarnings
to the test suite to ensure that we're not introducing any new warnings?
Hi @oalders
That's brilliant idea and good catch.
Best Regards, Mohammad S Anwar
@manwar I apologize for losing track of this PR. Would you be able to resolve the conflicts and force-push your commits again?
Sure in a moment
@manwar is the feedback something you'd like to address? I promise to keep track of the PR this time. 😢
@manwar is the feedback something you'd like to address? I promise to keep track of the PR this time. 😢
Sure, I will look into this weekend, promise.
This is all messed up. I would rather create fresh pull request. Please ignore this pull request.
Hi,
Please review the PR.
Many Thanks. Best Regards, Mohammad S Anwar