search

libwww-perl / HTTP-Cookies

Objects that represent a "cookie jar"
https://metacpan.org/pod/HTTP::Cookies
Other
4 stars 17 forks source link

Whenever possible, use an absolute four digit year for Time::Local #52

Closed oalders closed 5 years ago

oalders commented 6 years ago

Apply patch from https://rt.cpan.org/Public/Bug/Display.html?id=124527

oalders commented 6 years ago

@genio ping

karenetheridge commented 6 years ago

As discussed on irc, since MacOS Classic is not an architecture anyone uses any longer (so far as we know), it is also an option to do nothing (close this PR), or drop support for that architecture entirely.

genio commented 6 years ago

While I don't think there's any reason to keep this around further, I agree that using a four-digit year is good practice. If we leave the block in place, let's at least do that much. Can you alter the PR to not change the function used so we don't worry about that and simply alter the two-digit year to be a four-digit year?

oalders commented 6 years ago

I think my preference at this point is just to remove that block of code. Does that work for you?

genio commented 5 years ago

Dropping support for the architecture sounds good (block removal).