search

libwww-perl / HTTP-Cookies

Objects that represent a "cookie jar"
https://metacpan.org/pod/HTTP::Cookies
Other
4 stars 17 forks source link

do not set discard if max-age set #61

Closed robnagler closed 3 years ago

oalders commented 4 years ago

Thanks @robnagler! Would you be able to add an appropriate test for this?

robnagler commented 4 years ago

@oalders I tested the fix against our test. We wrap HTTP::Cookies so we could push out fixes independently. I'm fine if you don't merge this. I just wanted to let you know that there is a problem and how to fix it.

oalders commented 4 years ago

@robnagler understood. I appreciate the contribution. 👍

oalders commented 4 years ago

@robnagler do you mind if we keep this issue open?

robnagler commented 4 years ago

I thought it was not wanted. It's been 6 months. It's your call. I was just cleaning up my pulls.

oalders commented 4 years ago

The wheels are just turning slowly. ;) The change just needs an accompanying test that I'm hoping someone will contribute. We are understaffed over here. It's not a reflection on the PR.