search

libwww-perl / LWP-Protocol-https

Provide https support for LWP::UserAgent
https://metacpan.org/pod/LWP::Protocol::https
Other
16 stars 35 forks source link

Adds coverage tests #51

Closed JJ closed 7 years ago

JJ commented 7 years ago

Following the example of @moose, but it's pretty much the same you pointed me to. For the time being, it prints coverage in the logs (spoiler: not good) but I guess that if it finds a matching repo in coveralls.io, which you said you had set up, it should upload it there. Tell me if it does not work

JJ commented 7 years ago

Hey, who would've said that. It works. I love it when that happens.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 27cfedab18e050e87a6abf5323c83964c852b18c on JJ:master into on libwww-perl:master.

JJ commented 7 years ago

Address issue #50 . This is the suggestion I received.

JJ commented 7 years ago

2017-05-28 19:49 GMT+02:00 Karen Etheridge notifications@github.com:

@karenetheridge commented on this pull request.

As long as we support these perl versions we should continue to test them on travis.

The problem is that they error with the tooling needed for coveralls; the actual code works without a problem. I don't know if it can be fixed in the .travis.yml; my suggestion would be to add CI in another site.

karenetheridge commented 7 years ago

We can run the code coverage tests on just one version of perl (say 5.22 or 5.24) while running the user-facing tests across all perls that we support. We should not sacrifice the latter to get the former.

On Sun, May 28, 2017 at 10:52 AM, Juan Julián Merelo Guervós < notifications@github.com> wrote:

2017-05-28 19:49 GMT+02:00 Karen Etheridge notifications@github.com:

@karenetheridge commented on this pull request.

As long as we support these perl versions we should continue to test them on travis.

The problem is that they error with the tooling needed for coveralls; the actual code works without a problem. I don't know if it can be fixed in the .travis.yml; my suggestion would be to add CI in another site.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/libwww-perl/LWP-Protocol-https/pull/51#issuecomment-304529686, or mute the thread https://github.com/notifications/unsubscribe-auth/AASfy2WIo5YED4ylk58lewQ5-5UgvJclks5r-bRKgaJpZM4Nos23 .

JJ commented 7 years ago

2017-05-28 19:54 GMT+02:00 Karen Etheridge notifications@github.com:

We can run the code coverage tests on just one version of perl (say 5.22 or 5.24) while running the user-facing tests across all perls that we support. We should not sacrifice the latter to get the former.

That's exactly what that file does. But it installs tooling independently of the value of the environment variable. I can try and see if I can install the coverall tooling conditionally based on that variable. In fact, Moo and Moose seem to do it that way. I can try that.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling b462f10077a39b52684fba98aef3368fe44babe0 on JJ:master into on libwww-perl:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 2fb40008baaabc6c707d61e5a915676a1008a035 on JJ:master into on libwww-perl:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 087acdb21d39d62314b29fbdd8f5bd3edcb89c41 on JJ:master into on libwww-perl:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 087acdb21d39d62314b29fbdd8f5bd3edcb89c41 on JJ:master into on libwww-perl:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 087acdb21d39d62314b29fbdd8f5bd3edcb89c41 on JJ:master into on libwww-perl:master.

JJ commented 7 years ago

It's testing OK now. I only had to change the copyright year in dist.ini. The gist of it is that there's some rule in dist.ini that makes it check that, and that using build-dist was triggering installation of Dist::Zilla and rules, while the previous Travis CI wasn't doing that. Boils down to: it's got coverage testing now, and it also tests for all versions of perl previously used.

JJ commented 7 years ago

Squashed into two commits, most of the things in the second one. Changes requested done.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 7c2b8765e8342c1c008649c0a278c33af7b07beb on JJ:master into on libwww-perl:master.

oalders commented 7 years ago

Thanks very much @JJ!

JJ commented 7 years ago

Thanks!

2017-06-04 18:15 GMT+02:00 Olaf Alders notifications@github.com:

Merged #51 https://github.com/libwww-perl/LWP-Protocol-https/pull/51.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libwww-perl/LWP-Protocol-https/pull/51#event-1109167346, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAB9PFA5tCPzfzie-im69pJYoOkulaSks5sAtg_gaJpZM4Nos23 .

-- JJ