search

libwww-perl / LWP-Protocol-https

Provide https support for LWP::UserAgent
https://metacpan.org/pod/LWP::Protocol::https
Other
16 stars 35 forks source link

t/apache.t fails when apache.org changes content #67

Closed ahollandECS closed 1 year ago

ahollandECS commented 1 year ago

Currently, https://apache.org/ does not say "Apache Software Foundation" anywhere on it, so the test is failing. It should probably either be removed or pointed somewhere else.

oalders commented 1 year ago

Yikes! Yes, I think that line should be removed. Probably that file should also be moved from .t/ to .xt/.

We would accept a PR for this.

Thoughts, @karenetheridge?

oalders commented 1 year ago

That test passes for me right now, so maybe it was a transient thing. Still would be helpful not to depend on content being on a 3rd party page.

simbabque commented 1 year ago

I agree. IIRC there is one in LWP itself as well that does this. Or have we removed that recently?

oalders commented 1 year ago

This should hopefully be fixed via #69. Thanks for reporting @ahollandECS!