search

libwww-perl / URI

The Perl URI module
https://metacpan.org/pod/URI
Other
41 stars 48 forks source link

Escape square brackets in path #100

Closed Perlbotics closed 2 years ago

Perlbotics commented 2 years ago

Hi Olaf (@oalders) - here's the pull request. I've split the commits into groups for easy cherrypicking. Cheers/PB

Fixes #99

Perlbotics commented 2 years ago

Hi Olaf (@oalders),

I've fixed the typos that prevented the workflow from succeeding and fixed some setters while adding more tests. I could also run dzil w/o problems (on URI package only).

Perhaps a note to CONTRIBUTING.md could be added that a successful installation of spellchecking modules requires a LANG=C environment? At least Test::Spelling and perhaps also Dist::Zilla::Plugin::Test::PodSpelling required this setting here on my host. I.e. LANG=C dzil authordeps --missing | cpanm

Thanks PB

Perlbotics commented 2 years ago

Fixed POD again m( Sorry, not catched before.

simbabque commented 2 years ago

It looks like my review tab didn't refresh when you pushed the POD fix. I've amended that now.

Perlbotics commented 2 years ago

Hi Olaf (@oalders), I consider the work ready for the next iteration (of spell checking). Please approve the build workflow to see what happens next. Thank you.

oalders commented 2 years ago

@simbabque looks like this is ready for another review.

Perlbotics commented 2 years ago

Hi Olaf (@oalders), seems, it's ready for another (final?) workflow approval. Thanks.

oalders commented 2 years ago

Build is now queued. 😄

oalders commented 2 years ago

@simbabque all checks are now passing.

oalders commented 2 years ago

Thanks @Perlbotics and @simbabque! I squashed the commits at the command line and merged them into master via f4183117b1b19fc66.

oalders commented 2 years ago

I've uploaded URI 5.11 to CPAN. It was a long journey. Thanks for being patient. 😄