Like #107 I believe this gives a much nicer UX for future developers and maintainers of this codebase, also the line savings definitely don't hurt!
To aid review, since this is a big change, I've tried to be very minimal in what I change, I don't add test names and most assertions are just the same but wrapped in an ok unless it was trivial to use is or like.
I think this port even found a bug! In t/ldap.t we do:
Like #107 I believe this gives a much nicer UX for future developers and maintainers of this codebase, also the line savings definitely don't hurt!
To aid review, since this is a big change, I've tried to be very minimal in what I change, I don't add test names and most assertions are just the same but wrapped in an
ok
unless it was trivial to useis
orlike
.I think this port even found a bug! In
t/ldap.t
we do:Those prints were in the wrong order as both
not
s appeared before bothok
s.