search

libwww-perl / URI

The Perl URI module
https://metacpan.org/pod/URI
Other
57 stars 48 forks source link

Adding icap and icaps URIs #130

Closed david-dick closed 1 year ago

david-dick commented 1 year ago

Can we add these URI types? I would like to remove them from my Net::ICAP::Client module.

oalders commented 1 year ago

Thanks for this! I'm going to close and re-open to try to kick off a CI build.

david-dick commented 1 year ago

Yup, no problems. fixes applied.

oalders commented 1 year ago

If we want to merge these in, I'll need you to transfer maint on both of these modules to me OALDERS.

Also, I see the existing modules on CPAN include documentation. Could we include the documentation in this pull request as well?

david-dick commented 1 year ago

maint granted

oalders commented 1 year ago

maint granted

It looks like you granted co-maint, but if we're going to take this over as an ongoing thing in URI I would actually need maint, as I do on the other modules. That will allow us to grant co-maint to other team members etc.

david-dick commented 1 year ago

okay, tried again.

oalders commented 1 year ago

Would you be able to add the Pod to the lib files as well? It's probably mostly a copy/paste from the existing modules.

david-dick commented 1 year ago

yup, I can do that. might take a day or so. bit busy atm.

david-dick commented 1 year ago

okay, documentation added.

oalders commented 1 year ago

Great! Are you able to release a new version of Net::ICAP::Client without these modules? Once that is done I can release a new URI. I think that might be the least confusing way to do this.

haarg commented 1 year ago

With the permissions transferred, it makes more sense to release a new URI with this PR before a new Net::ICAP::Client with the URI modules removed.

david-dick commented 1 year ago

Yeah, I would like to release a new Net::ICAP::Client with the correct minimum version for URI in PREREQ_PM. I can't do that until URI with URI::icap and URI::icaps is released.

oalders commented 1 year ago

Thanks @david-dick! Merged via 58ecb135be0b561b2abea9202b5816310f8257bd. I will release a new URI shortly.