libwww-perl / WWW-Mechanize

Handy web browsing in a Perl object
https://metacpan.org/pod/WWW::Mechanize
Other
68 stars 53 forks source link

capture script links [enhancement, patch] #206

Open spazm opened 7 years ago

spazm commented 7 years ago

dmt3.14...@gmail.com reported on Jan 2, 2012

In the absence of a real perl javascript we can't actually use the content.
However I use WWW::Mechanize for testing web site logins for our monitoring
system and think it is useful to fetch script links, as problems loading
such links are usually reflected in the user experience.

--- WWW-Mechanize-1.71.orig/lib/WWW/Mechanize.pm    2011-11-26 04:33:10.000000000 +1000
+++ WWW-Mechanize-1.71/lib/WWW/Mechanize.pm 2012-01-01 08:56:59.000000000 +1000
@@ -2536,6 +2539,7 @@
     iframe => 'src',
     link   => 'href',
     meta   => 'content',
+    script => 'src',
 );

 sub _extract_links {

Details

Imported from Google Code issue 229 via archive

DannyThomas commented 5 years ago

you could quibble whether it's a defect or enhancement but is there any reason this 1-line change can't be made ?

I get reminded with each release when I have to produce a patch corresponding to the distribution.

oalders commented 5 years ago

I think this is fine. It probably hasn't been acted on because we're low on people power.

We could speed this up process with a pull request and an accompanying test. Does that sound reasonable?

DannyThomas commented 5 years ago

On 3 December 2018 at 11:08:06 am, Olaf Alders (notifications@github.com) wrote:

We could speed this up process with a pull request and an accompanying test.

Does that sound reasonable?

That sounds good, but I’ve had health issues so probably won’t happen for a while

Danny

oalders commented 5 years ago

Hi Danny,

Take good care of yourself! We'll keep this open until it's deal with.

Olaf