search

libwww-perl / WWW-Mechanize

Handy web browsing in a Perl object
https://metacpan.org/pod/WWW::Mechanize
Other
68 stars 52 forks source link

tick() now dies if checkbox is not found #248

Closed oalders closed 6 years ago

oalders commented 6 years ago

This behaviour is now in line with the documentation.

Fixes #239

petdance commented 6 years ago

Looks fine to me. That "got self far" instead of "got this far" is kind of amusing. :-)

oalders commented 6 years ago

Thanks @petdance! I did check the commit that introduced "got self far" and I confirmed that it was only a typo and not some comment that I just didn't understand. :)

petdance commented 6 years ago

It seemed to me that maybe someone was making a global search and replace from "this" to "self", like they were coming from PHP or something because PHP's standard is this for the object you're in.

oalders commented 6 years ago

Ah, you're right, that's the find and replace that triggered it, but I'm not sure if it was someone coming from PHP. ;) https://github.com/libwww-perl/WWW-Mechanize/commit/e25b0582

petdance commented 6 years ago

Ha! Back in 2003, I was indeed doing a lot of PHP. :-)