libwww-perl / WWW-Mechanize

Handy web browsing in a Perl object
https://metacpan.org/pod/WWW::Mechanize
Other
68 stars 52 forks source link

t/local/*.t may hang #278

Open eserte opened 5 years ago

eserte commented 5 years ago

Recently the WWW::Mechanize test suite started to hang on some my smokers (various OS, various perl versions). The hangs always happened in some of the t/local/*.t tests: mostly referer.t or back.t, sometimes also encoding.t. Before the hanging test it seems that there was always a "Connection refused" error. Sample reports on CPAN Testers:

genio commented 5 years ago

Thanks, @eserte This is due to #272 and #101

HTTP::Daemon was updated to be IPv6 compatible. The tests herein need to be fixed to accommodate the possibility of an IPv6 socket being opened.

skaji commented 5 years ago

@eserte Can you try https://github.com/libwww-perl/WWW-Mechanize/pull/280 ?

skaji commented 5 years ago

@eserte If #280 does not work for you, could you also run this script? https://gist.github.com/skaji/d0a71d9f02576a2f529798e1d8f6a98d

See also https://github.com/libwww-perl/HTTP-Daemon/issues/33

eserte commented 5 years ago

The t/local* tests were always hanging with the system perl on my centos7 smoker, and are still hanging with #280. On two other configurations there were no problems.

The gist already dies on the $Net::HTTP::SOCKET_CLASS eq 'IO::Socket::IP' or die; line.

skaji commented 5 years ago

@eserte Both #280 and the gist assume that you have HTTP::Daemon 6.05+ (and its dependency IO::Socket::IP).

So could you try again #280 and the gist after installing HTTP::Daemon 6.05+?

eserte commented 5 years ago

I'd say: ignore the problems on the centos7 machine with the system perl --- WWW::Mechanize's test suite was always hanging here, so maybe it's a different problem (and doing stuff on this configuration is a little bit difficult for me, because of policy decisions I do not install anything here, just run CPAN.pm with the test action).

For other systems it seems that the PR code solves the problems. So a 👍 from me for the PR.

jkeenan commented 1 year ago

I'd say: ignore the problems on the centos7 machine with the system perl --- WWW::Mechanize's test suite was always hanging here, so maybe it's a different problem (and doing stuff on this configuration is a little bit difficult for me, because of policy decisions I do not install anything here, just run CPAN.pm with the test action).

For other systems it seems that the PR code solves the problems. So a +1 from me for the PR.

Can you tell us whether this problem has cleared up now that there have been new CPAN releases of WWW-Mechanize and HTTP-Daemon?