libwww-perl / WWW-Mechanize

Handy web browsing in a Perl object
https://metacpan.org/pod/WWW::Mechanize
Other
68 stars 52 forks source link

Revert "set dist trusty for old perls" #294

Closed oalders closed 4 years ago

oalders commented 4 years ago

Reverts libwww-perl/WWW-Mechanize#279

oalders commented 4 years ago

The failing tests are in xt/author/live

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 318


Totals Coverage Status
Change from base Build 307: 0.9%
Covered Lines: 736
Relevant Lines: 782

💛 - Coveralls
skaji commented 4 years ago

https://travis-ci.org/github/libwww-perl/WWW-Mechanize/builds/667636368

$ make TEST_VERBOSE=1 TEST_FILES='xt/author/live/*.t' test || true
PERL_DL_NONLAZY=1 "/home/travis/perl5/perlbrew/perls/5.10/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(1, 'blib/lib', 'blib/arch')" xt/author/live/*.t
xt/author/live/encoding.t ... 
not ok 1 - Test::Needs modules available
1..1
# Failed test 'Test::Needs modules available'
# at /home/travis/perl5/perlbrew/perls/5.10/lib/site_perl/5.10.1/Test/Needs.pm line 96.
# Need LWP::Protocol::https due to RELEASE_TESTING
# Looks like you failed 1 test of 1.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
xt/author/live/wikipedia.t .. 
1..1
not ok 1 - Test::Needs modules available
# Need LWP::Protocol::https due to RELEASE_TESTING
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
Test Summary Report
-------------------
xt/author/live/encoding.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
xt/author/live/wikipedia.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=2, Tests=2,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.05 cusr  0.00 csys =  0.07 CPU)
Result: FAIL
Failed 2/2 test programs. 2/2 subtests failed.

5.10 and 5.12 fail because Test::Needs and LWP::Protocol::https are not available.

oalders commented 4 years ago

Thanks for the review and the troubleshooting @skaji!