libwww-perl / WWW-Mechanize

Handy web browsing in a Perl object
https://metacpan.org/pod/WWW::Mechanize
Other
68 stars 52 forks source link

Bump HTTP::Daemon test dependency to 6.12 #300

Closed oalders closed 4 years ago

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 360


Totals Coverage Status
Change from base Build 347: 0.0%
Covered Lines: 758
Relevant Lines: 804

💛 - Coveralls
skaji commented 4 years ago

HTTP::Daemon 6.10 returns a correct $d->url so that we don't need workarounds anymore: https://github.com/libwww-perl/WWW-Mechanize/blob/f1a023556bc367ce56d8f9d30086f2e2083cc42a/t/local/log-server#L16-L23 https://github.com/libwww-perl/WWW-Mechanize/blob/f1a023556bc367ce56d8f9d30086f2e2083cc42a/t/local/referer-server#L10-L17

@oalders Could you remove these lines?

oalders commented 4 years ago

@skaji I have removed the lines. Is that what you had in mind?

oalders commented 4 years ago

Thanks @skaji. I've applied your diff in 44649ef8e46497f4