search

libwww-perl / WWW-Mechanize

Handy web browsing in a Perl object
https://metacpan.org/pod/WWW::Mechanize
Other
68 stars 52 forks source link

Replace use of discouraged vars pragma with my #313

Closed JRaspass closed 3 years ago

JRaspass commented 3 years ago

Works on v5.6+ which this dist supports and our is already used.

skaji commented 3 years ago

@JRaspass Thanks.

It seems that we don't even need to make %urls a global variable here. So could you replace our with my?

JRaspass commented 3 years ago

@skaji Good shout, a grep shows no other callers of the package var and it wouldn't make much sense to access it after the for loop had ran so I've made it a lexical and everything still passes.

oalders commented 3 years ago

Thanks @JRaspass!