search

libwww-perl / WWW-Mechanize

Handy web browsing in a Perl object
https://metacpan.org/pod/WWW::Mechanize
Other
68 stars 52 forks source link

mech-dump errors when a request failed #292 #343

Closed simbabque closed 1 year ago

simbabque commented 2 years ago

Fixes #292

codecov[bot] commented 2 years ago

Codecov Report

Merging #343 (9b21afa) into master (9b21afa) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 9b21afa differs from pull request most recent head e92b85b. Consider uploading reports for the commit e92b85b to get more accurate results

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   88.73%   88.73%           
=======================================
  Files           3        3           
  Lines         852      852           
  Branches      232      232           
=======================================
  Hits          756      756           
  Misses         36       36           
  Partials       60       60

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

simbabque commented 2 years ago

Done, thanks.

oalders commented 1 year ago

Any idea what's up with the Windows failures?

simbabque commented 1 year ago

Any idea what's up with the Windows failures?

Not exactly. I found https://stackoverflow.com/a/32054866/1331451, which points to something with system setting $? to -1 on Windows in 5.14 (and possibly 5.16?) being broken. If that is the case, it must have been fixed later, but I could not find any fixes in perldelta. I have now skipped this one test case on these versions.

Please have another look. Thanks.