libwww-perl / WWW-Mechanize

Handy web browsing in a Perl object
https://metacpan.org/pod/WWW::Mechanize
Other
68 stars 52 forks source link

run test that captures STDERR without taint mode #350 #353

Closed simbabque closed 1 year ago

simbabque commented 1 year ago

It seems that on certain Windows versions File::Temp is not working properly when run under taint mode. This problem must have been around for a while. Test::Output uses File::Temp, and therefore runs into this problem as our mech-dump.t has had the -T flag enabled. I do not know why we run under taint for some tests, but I have decided the most pragmatic fix is to undo my previous changes from #292 to the test an to move this particular test into its own file, which can run without taint.

Also see https://www.perlmonks.org/?node_id=1122816 for details on the original problem.

Closes #350.

codecov[bot] commented 1 year ago

Codecov Report

Base: 88.85% // Head: 88.85% // No change to project coverage :thumbsup:

Coverage data is based on head (61acaea) compared to base (5b2cdbf). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #353 +/- ## ======================================= Coverage 88.85% 88.85% ======================================= Files 3 3 Lines 861 861 Branches 236 236 ======================================= Hits 765 765 Misses 36 36 Partials 60 60 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libwww-perl). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libwww-perl)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.