libwww-perl / WWW-Mechanize

Handy web browsing in a Perl object
https://metacpan.org/pod/WWW::Mechanize
Other
68 stars 52 forks source link

Prefer q{} over '' #354

Closed oalders closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Base: 88.85% // Head: 88.85% // No change to project coverage :thumbsup:

Coverage data is based on head (dc247f5) compared to base (d8ffd8d). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #354 +/- ## ======================================= Coverage 88.85% 88.85% ======================================= Files 3 3 Lines 861 861 Branches 236 236 ======================================= Hits 765 765 Misses 36 36 Partials 60 60 ``` | [Impacted Files](https://codecov.io/gh/libwww-perl/WWW-Mechanize/pull/354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libwww-perl) | Coverage Δ | | |---|---|---| | [lib/WWW/Mechanize.pm](https://codecov.io/gh/libwww-perl/WWW-Mechanize/pull/354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libwww-perl#diff-bGliL1dXVy9NZWNoYW5pemUucG0=) | `88.37% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libwww-perl). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libwww-perl)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

haarg commented 1 year ago

Do we have a perlcritic rule for this?

oalders commented 1 year ago

We haven't been able to introduce perlcritic yet. Now that the PRs have been cleared out, we can start to ramp up on code quality etc.

oalders commented 1 year ago

This is just using my own fork of https://metacpan.org/pod/App::PerlNitpick. I'm just messing around with it to see where it breaks and it seemed fine on this repo.