fix invalid needle defaults error - Githubissues

libxmljs / libxmljs-dom

A simple DOM wrapper for libxmljs

13 stars 14 forks source link

fix invalid needle defaults error #11

Open jfsimon opened 5 years ago

jfsimon commented 5 years ago

The compressed and rejectUnauthorized options are not allowed in needle.defaults. They're respectively HttpHeader (https://github.com/tomas/needle#http-header-options) and HttpRequest (https://github.com/tomas/needle#nodejs-tls-options) options.

Since v2.3.1, needle throws an error because of these 2 options (https://github.com/tomas/needle/blob/master/lib/needle.js#L775), I guess they were just noop before that. Unit tests are failing with latest version of needle without this patch.

czosel commented 4 years ago

@rchipka I just ran into this as well. Is there anything blocking this? It would be great to get this merged :slightly_smiling_face: