search

libxmp / xmp-cli

Command-line mod player using libxmp
GNU General Public License v2.0
75 stars 22 forks source link

add --with-libxmp-lite to build against libxmp-lite instead of libxmp. #23

Closed sezero closed 3 years ago

sezero commented 3 years ago

Otherwise, if only libxmp-lite is installed, xmp-cli configury fails.

cmatsuoka commented 3 years ago

I wonder if this couldn't be done using --with-libxmp=... to specifiy the lite library instead of the regular one.

cmatsuoka commented 3 years ago

Looking at the autoconf documentation, it seems that --with-libxmp-lite is what we want?

sezero commented 3 years ago

Re-worked the patch to use --with-libxmp=... configure switch.

sezero commented 3 years ago

Looking at the autoconf documentation, it seems that --with-libxmp-lite is what we want?

That sounds simpler and I can do that. But if I ignore any possible given value, --without-libxmp-lite would still switch to using libxmp-lite. What is it that you prefer?

cmatsuoka commented 3 years ago

Using --without-libxmp-lite and still link libxmp-lite seems wrong. Since --without-libxmp-lite is equivalent to --with-libxmp-lite=no, I think we can switch to libxmp-lite only if the value is set and not "no", so that:

./configure -> libxmp ./configure --with-libxmp-lite -> libxmp-lite ./configure --without-libxmp-lite -> libxmp

If we decide later to allow options to libxmp-lite, we could use --with-libxmp-lite=<some argument> (as long as the argument isn't "no".)

sezero commented 3 years ago

./configure -> libxmp ./configure --with-libxmp-lite -> libxmp-lite ./configure --without-libxmp-lite -> libxmp

Re-worked patch to use --with-libxmp-lite with checking with_val to adjust accordingly.