search

libxmp / xmp-cli

Command-line mod player using libxmp
GNU General Public License v2.0
75 stars 22 forks source link

Fix loop toggle #43

Closed genericrandom64 closed 2 years ago

genericrandom64 commented 2 years ago

Toggling loop previously took two presses but this changes it to only need one

AliceLR commented 2 years ago

I think this is actually supposed to be an intentional feature... checking main.c, a value of 1 is used to loop the current module/sequence (--loop), but after every module has finished playing, a value of 2 loops the entire module list (--loop-all). Also see option.c. Both seem useful, but the toggle for it certainly has an unusual implementation, and the display doesn't indicate the difference...

This patch in its current state would exclude module list looping from the toggle. I don't have any good recommendations for this right now.

sezero commented 2 years ago

Reject?