libxmp / xmp-cli

Command-line mod player using libxmp
GNU General Public License v2.0
75 stars 22 forks source link

malloc'ing sound_file and sound_wav descriptions really necessary? #58

Closed sezero closed 1 year ago

sezero commented 1 year ago

sound_file.c and sound_wav.c change their const char* descriptions to malloc'ed buffers to include the output file. sound_aiff.c does not do that - possibly forgotten or considered unnecessary when it was written.

Is this extra malloc'ing truly necessary? Can we just remove them?

sezero commented 1 year ago

Removed by PR #59. Closing.