search

libyal / libesedb

Library and tools to access the Extensible Storage Engine (ESE) Database File (EDB) format.
GNU Lesser General Public License v3.0
338 stars 91 forks source link

test_library.sh fails on some 32bit architectures #26

Closed hillu closed 7 years ago

hillu commented 7 years ago

On Debian's armel, armhf, i386, hppa, powerpc, x32 autobuilders, the tests fail with

esedb_test_data_segment.c:135 result (1) != -1
Unable to run test: libesedb_data_segment_initialize
Testing: data_segment  (FAIL)
joachimmetz commented 7 years ago

Any information in tests/test-suite.log that indicates why the test is failing?

joachimmetz commented 7 years ago

https://github.com/libyal/libesedb/blob/master/tests/esedb_test_data_segment.c#L127

At first glance this looks like the bounds check is missing in: https://github.com/libyal/libesedb/blob/b5abe2d05d5342ae02929c26475774dbb3c3aa5d/libesedb/libesedb_data_segment.c#L38

I've added it in https://github.com/libyal/libesedb/commit/0eb2efbc87440772726eab943c3762eaf1ed1c1e

if this is still failing, and to get more details, try running:

make check CHECK_WITH_STDERR=1;
hillu commented 7 years ago

I've added it in 0eb2efb

Hi Joachim,

with your patch, my build passes on i386. Thanks.

Cheers, -Hilko

hillu commented 7 years ago

According to https://buildd.debian.org/status/package.php?p=libesedb, libesedb can now again be built on all the architectures. Thank you.