search

libyal / libfvde

Library and tools to access FileVault Drive Encryption (FVDE) encrypted volumes
GNU Lesser General Public License v3.0
339 stars 34 forks source link

dfvfs unit test fails with libfvde experimental-20180108 #33

Closed ant1 closed 6 years ago

ant1 commented 6 years ago

Hi,

With version experimental-20180108, 1 regression test from dfvfs fails:

======================================================================
ERROR: testScanFVDE (helpers.source_scanner.SourceScannerTest)
Test the Scan function on FVDE.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/wrkdirs/dfvfs-20171230/tests/helpers/source_scanner.py", line 182, in testScanFVDE
    self._source_scanner.Scan(scan_context)
  File "./dfvfs/helpers/source_scanner.py", line 565, in Scan
    self._ScanNode(scan_context, scan_node, auto_recurse=auto_recurse)
  File "./dfvfs/helpers/source_scanner.py", line 440, in _ScanNode
    scan_context, sub_scan_node, auto_recurse=auto_recurse)
  File "./dfvfs/helpers/source_scanner.py", line 450, in _ScanNode
    file_object.close()
  File "./dfvfs/file_io/file_io.py", line 98, in close
    self._Close()
  File "./dfvfs/file_io/file_object_io.py", line 35, in _Close
    self._file_object.close()
IOError: pyfvde_volume_close: unable to close volume. libfvde_volume_close: invalid volume - missing file IO handle.

----------------------------------------------------------------------
joachimmetz commented 6 years ago

This looks more than a dormant bug in dfvfs than regression in libfvde. Since the pyfvde volume seems to be closed multiple times.

ant1 commented 6 years ago

A workaround was added and the issue was not in libfvde itself.