Open Woniuke opened 3 years ago
@Woniuke thx for the PR, I'll have a closer look when time permits, unfortunately time is limited at the moment, so this might take a bit
Merging #18 (2f988f2) into main (a381170) will increase coverage by
7.18%
. The diff coverage is96.87%
.:exclamation: Current head 2f988f2 differs from pull request most recent head 1537de1. Consider uploading reports for the commit 1537de1 to get more accurate results
@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 52.49% 59.68% +7.18%
==========================================
Files 42 33 -9
Lines 3821 2865 -956
==========================================
- Hits 2006 1710 -296
+ Misses 1815 1155 -660
Impacted Files | Coverage Δ | |
---|---|---|
libfwsi/libfwsi_item.c | 43.66% <80.00%> (-0.01%) |
:arrow_down: |
libfwsi/libfwsi_control_panel_cpl_file_values.c | 85.71% <100.00%> (-11.51%) |
:arrow_down: |
libfwsi/libfwsi_uri_sub_values.c | 47.50% <0.00%> (-20.80%) |
:arrow_down: |
libfwsi/libfwsi_game_folder_values.c | 76.19% <0.00%> (-19.16%) |
:arrow_down: |
libfwsi/libfwsi_control_panel_values.c | 76.19% <0.00%> (-19.16%) |
:arrow_down: |
libfwsi/libfwsi_control_panel_category_values.c | 43.18% <0.00%> (-19.05%) |
:arrow_down: |
...ibfwsi/libfwsi_extension_block_0xbeef0001_values.c | 43.18% <0.00%> (-19.05%) |
:arrow_down: |
...ibfwsi/libfwsi_extension_block_0xbeef0005_values.c | 43.18% <0.00%> (-19.05%) |
:arrow_down: |
...ibfwsi/libfwsi_extension_block_0xbeef0019_values.c | 43.18% <0.00%> (-19.05%) |
:arrow_down: |
...ibfwsi/libfwsi_extension_block_0xbeef0003_values.c | 77.27% <0.00%> (-18.29%) |
:arrow_down: |
... and 32 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a381170...1537de1. Read the comment docs.
@Woniuke thx for the change, I'll have a closer look when time permits, unfortunately time is limited at the moment, so this might take a bit. Could you make this into a PR ?
:smile: Did you want me to make this commit as another PR?
Did you want me to make this commit as another PR?
ah for some reason this looked like a separate change differently in the github UI, no need for an additional PR then
I find some bugs in documents which make it shows incorrectly