search

libyal / libpff

Library and tools to access the Personal Folder File (PFF) and the Offline Folder File (OFF) format
GNU Lesser General Public License v3.0
286 stars 74 forks source link

Reset the result flag after use #133

Open ztravis opened 1 month ago

ztravis commented 1 month ago

I think this is a bug - the result variable is used for the result of this initial computation but isn't cleared afterwards. If the subsequent traversal fails to find a leaf node, it's possible for it to return this old value.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.99%. Comparing base (2b160d2) to head (aa176c7).

Files Patch % Lines
libpff/libpff_local_descriptors.c 0.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (2b160d2) and HEAD (aa176c7). Click for more details.

HEAD has 2 uploads less than BASE | Flag | BASE (2b160d2) | HEAD (aa176c7) | |------|------|------| ||4|2|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #133 +/- ## ========================================== - Coverage 23.66% 14.99% -8.67% ========================================== Files 63 63 Lines 20608 20609 +1 Branches 4966 4966 ========================================== - Hits 4876 3091 -1785 - Misses 14615 16989 +2374 + Partials 1117 529 -588 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.