make pypff Python3 compatible

[TimRepke]

I constantly got errors by setup.py during installation of the package. After these changes (sorry, my IDE messed with the indentation) things worked for me using Python 3.6.6

Essentially, Python 3 handles str/bytes differently, that's all

[joachimmetz]

Sorry, my IDE messed with the indentation

This makes it hard for me to see what has changed.

I constantly got errors by setup.py during installation of the package

Can you provide me with the error messages?

Also know pypff is work in progress https://github.com/libyal/libpff/issues/2

[codecov[bot]]

Codecov Report

Merging #68 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   33.53%   33.53%           
=======================================
  Files          53       53           
  Lines       19454    19454           
=======================================
  Hits         6523     6523           
  Misses      12931    12931

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2e2d1c...f3f65b0. Read the comment docs.

[TimRepke]

Can you provide me with the error messages?

Unfortunately not really. I do have this screenshot though. All the errors were along the same kind.

Also know pypff is work in progress #2

I saw that but assumed it stagnated as it's from 2014. Everything else works fine, just the setup script had errors.

This makes it hard for me to see what has changed.

True. Tried to fix it. Not sure if your interpreter is not as strict as mine, but I had to change some indentation, otherwise Python tells me, that the indentation is not all the same.

[joachimmetz]

Unfortunately not really. I do have this screenshot though. All the errors were along the same kind.

Thanks, that is sufficient.

I saw that but assumed it stagnated as it's from 2014. Everything else works fine, just the setup script had errors.

I have limited time to work on it.

True. Tried to fix it. Not sure if your interpreter is not as strict as mine, but I had to change some indentation, otherwise Python tells me, that the indentation is not all the same.

I'll have a look to see what changed and make the changes manually. For your context setup.py is generated by https://github.com/libyal/libyal/blob/master/scripts/source-generate.py

[joachimmetz]

@TimRepke thanks for the proposed changes though I'll not directly merge this PR. Since setup.py is generated elsewhere and this PR will need some clean up. I'll incorporate the necessary changes and regenerate setup.py for libpff.

Tracking changes to setup.py in https://github.com/libyal/libyal/issues/63 I'll close this PR once a regenerated setup.py has been committed for libpff.

[joachimmetz]

Adopted version of proposed changes integrated into https://github.com/libyal/libpff/commit/fecb6912675472d39204642ba03835c9fbff5c16