search

libyal / libpff

Library and tools to access the Personal Folder File (PFF) and the Offline Folder File (OFF) format
GNU Lesser General Public License v3.0
289 stars 74 forks source link

Add method to get attachment name #69

Open sunu opened 6 years ago

sunu commented 6 years ago

Hi @joachimmetz ,

I have added a method/property to get the name of attachments. It's mostly mirroring how getting names work on folder objects. It would be amazing if you could take a look and let me know if it looks alright.

Thanks.

joachimmetz commented 6 years ago

@sunu thanks for PR I'll have a look as soon as time permits.

wyllys66 commented 5 years ago

Is anyone going to follow up on this and complete it?

joachimmetz commented 5 years ago

when time permits, just FYI this is not a project with a vast amount of engineering resources.

wyllys66 commented 5 years ago

Understood. The test failure looked like a minor issue in the MacOS build and not a functional issue, but Im not sure how to address it or I'd try to help out.

akappner commented 5 years ago

sunu -- thanks for the patch, it solved my problem with reading the attachment names. Tested it (including the Python bindings), and it worked flawlessly (on Linux). I'll try to see if I can fix the test issue with OSX later.

apdullahyayik commented 4 years ago

akappner-- Can you explain where name of any attachment is stored and how to reach it ?

tbfs-account commented 4 years ago

I have tested this branch and it works successfully on Linux (Fedora + Debian).