libyal / libpff

Library and tools to access the Personal Folder File (PFF) and the Offline Folder File (OFF) format
GNU Lesser General Public License v3.0
289 stars 74 forks source link

python.m4 uses wrong print command for python3 #87

Closed wyllys66 closed 4 years ago

wyllys66 commented 4 years ago

The python.m4 template uses an invalid print statement in the tests for python3.

Line 449:

        [ax_python3_pythondir=`${PYTHON3} -c "import distutils.sysconfig; print distutils.sysconfig.get_python_lib() " 2>/dev/null`])],

The test should use parenthesis since in python3, print is a function:

        [ax_python3_pythondir=`${PYTHON3} -c "import distutils.sysconfig; print(distutils.sysconfig.get_python_lib()) " 2>/dev/null`])],

Also Line 458:

 ax_python3_library_dir=`${PYTHON3} -c "import distutils.sysconfig; print distutils.sysconfig.get_python_lib(True) " 2>/dev/null`; 

should be:

 ax_python3_library_dir=`${PYTHON3} -c "import distutils.sysconfig; print(distutils.sysconfig.get_python_lib(True)) " 2>/dev/null`; 
joachimmetz commented 4 years ago

thx for the report I'll have a look as soon as time permits

joachimmetz commented 4 years ago

Addressed in https://github.com/libyal/libpff/commit/34c48fb28e0d28f829d801d7bce646ef8eebe6d4#diff-359d523afb08173765a8cf63d0291c0e