search

libyal / libvmdk

Library and tools to access the VMware Virtual Disk (VMDK) format
GNU Lesser General Public License v3.0
168 stars 66 forks source link

Looks like the .am files need some work #13

Closed SkyLeach closed 7 years ago

SkyLeach commented 7 years ago 
configure.ac:38: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:38: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:38: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
configure.ac:208: error: required file 'libcerror/Makefile.in' not found
configure.ac:209: error: required file 'libcthreads/Makefile.in' not found
configure.ac:210: error: required file 'libcdata/Makefile.in' not found
configure.ac:211: error: required file 'libclocale/Makefile.in' not found
configure.ac:212: error: required file 'libcnotify/Makefile.in' not found
configure.ac:213: error: required file 'libcsplit/Makefile.in' not found
configure.ac:214: error: required file 'libuna/Makefile.in' not found
configure.ac:215: error: required file 'libcfile/Makefile.in' not found
configure.ac:216: error: required file 'libcpath/Makefile.in' not found
configure.ac:217: error: required file 'libbfio/Makefile.in' not found
configure.ac:218: error: required file 'libfcache/Makefile.in' not found
configure.ac:219: error: required file 'libfdata/Makefile.in' not found
configure.ac:220: error: required file 'libfvalue/Makefile.in' not found
configure.ac:222: error: required file 'libcsystem/Makefile.in' not found
Makefile.am:3: error: required directory ./libcerror does not exist
Makefile.am:3: error: required directory ./libcthreads does not exist
Makefile.am:3: error: required directory ./libcdata does not exist
Makefile.am:3: error: required directory ./libclocale does not exist
Makefile.am:3: error: required directory ./libcnotify does not exist
Makefile.am:3: error: required directory ./libcsplit does not exist
Makefile.am:3: error: required directory ./libuna does not exist
Makefile.am:3: error: required directory ./libcfile does not exist
Makefile.am:3: error: required directory ./libcpath does not exist
Makefile.am:3: error: required directory ./libbfio does not exist
Makefile.am:3: error: required directory ./libfcache does not exist
Makefile.am:3: error: required directory ./libfdata does not exist
Makefile.am:3: error: required directory ./libfvalue does not exist
Makefile.am:3: error: required directory ./libcsystem does not exist
autoreconf: automake failed with exit status: 1

It's been a lot of time since I've actually modified autoconf files, but if I'm reading this right it looks as though system include is being ignored.

These changes, however, do what is needed in setup.py to generate the configure script (assuming the .am files are correct).

joachimmetz commented 7 years ago

I'll not merge these changes, you are using a developer release not a distribution release.

joachimmetz commented 7 years ago

also your solution is brew centric which does not make it portable to macOS without brew, closing PR