search

libyal / libvmdk

Library and tools to access the VMware Virtual Disk (VMDK) format
GNU Lesser General Public License v3.0
163 stars 66 forks source link

Adding python consts file #17

Closed trikotrako closed 5 years ago

trikotrako commented 5 years ago

Adding python consts file Changing the setup.py script to copy pyvmdkconsts too

joachimmetz commented 5 years ago

What is the purpose of these changes? If you want to add the enums why not do this inside the python module shared object instead?

joachimmetz commented 5 years ago

I've added the disk and event types to the CPython bindings in https://github.com/libyal/libvmdk/commit/6a322399d6e2317be0b2660f65ed9a2ba54be104. To me it looks like that should address the intent of this PR

trikotrako commented 5 years ago

I thought the python enum object is easier and more convenient, but thanks for the commit!

joachimmetz commented 5 years ago

Unfortunately it adds another technology to the binding. I agree that the Python based solution is easier to develop, but unfortunately adds more complexity for maintenance.