search

libyal / libvmdk

Library and tools to access the VMware Virtual Disk (VMDK) format
GNU Lesser General Public License v3.0
168 stars 66 forks source link

Unsupported descriptor file encoding Shift_JIS #23

Closed mnrkbys closed 1 year ago

mnrkbys commented 4 years ago

I have encountered a problem which is similar to the libvmdk issue #10 . VMware Workstation on Windows Japanese edition sets "encoding" to "Shift_JIS" in "Disk Descriptor" of VMDK. But libvmdk and libclocale don't support it. Could you support Shift_JIS as same as GBK and Big5? By the way, Shift_JIS is mapped to cp932.

libvmdk_not_support_shift_jis_00

joachimmetz commented 4 years ago

@mnrkbys, thx for the report.

Could you support Shift_JIS as same as GBK and Big5?

I can. I'll update documentation and source as soon as time permits.

Are you aware of any edge cases where Shift_JIS would be (potentially) different from cp932?

In the mean time if you extend libvmdk/libvmdk_descriptor_file.c similar to https://github.com/libyal/libvmdk/commit/4b09bb827d9335a842ba6dd7e1e1f6cd47669504 that should get you the functionality you need

mnrkbys commented 4 years ago

Sorry, I am not familiar with character codes. So, I don't know what is the difference between Shift_JIS and cp932. I will try to make the patch. Thank you.

joachimmetz commented 1 year ago

Changes in https://github.com/libyal/libvmdk/commit/2094cdbca3cb7d11803b4a24e4d223bfab6cc80e