libyal / libvmdk

Library and tools to access the VMware Virtual Disk (VMDK) format
GNU Lesser General Public License v3.0
163 stars 66 forks source link

Support Shift_JIS encoding #31

Closed mnrkbys closed 1 year ago

mnrkbys commented 1 year ago

Updated libvmdk_descriptor.file.c to support Shift_JIS encodig (I have posted #23 in the past).

codecov[bot] commented 1 year ago

Codecov Report

Base: 43.88% // Head: 43.81% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (bc68594) compared to base (afed9e4). Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head bc68594 differs from pull request most recent head c3ff0ed. Consider uploading reports for the commit c3ff0ed to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #31 +/- ## ========================================== - Coverage 43.88% 43.81% -0.07% ========================================== Files 26 26 Lines 6945 6956 +11 ========================================== Hits 3048 3048 - Misses 3897 3908 +11 ``` | [Impacted Files](https://codecov.io/gh/libyal/libvmdk/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libyal) | Coverage Δ | | |---|---|---| | [libvmdk/libvmdk\_descriptor\_file.c](https://codecov.io/gh/libyal/libvmdk/pull/31/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libyal#diff-bGlidm1kay9saWJ2bWRrX2Rlc2NyaXB0b3JfZmlsZS5j) | `52.54% <0.00%> (-0.64%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libyal). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libyal)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

joachimmetz commented 1 year ago

Since the CI tests are failing, I've integrated similar changes into https://github.com/libyal/libvmdk/commit/2094cdbca3cb7d11803b4a24e4d223bfab6cc80e